Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: correct the usage of json.Unmarshal in DecodeArgs (#890) #896

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Jun 11, 2020

Cherry-pick #890

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #896 into release-3.0 will increase coverage by 0.14%.
The diff coverage is 64.16%.

@@               Coverage Diff               @@
##           release-3.0     #896      +/-   ##
===============================================
+ Coverage        64.36%   64.50%   +0.14%     
===============================================
  Files               31       31              
  Lines            11019    11104      +85     
===============================================
+ Hits              7092     7163      +71     
- Misses            3518     3524       +6     
- Partials           409      417       +8     

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jun 16, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@jackysp jackysp merged commit 4e23afb into pingcap:release-3.0 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants