sink: replace Kafka client with confluent-kafka-go #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please split this into multiple small PRs:
|
Most of files are deleted and there is no need to split. |
3AceShowHand
approved these changes
Jan 16, 2025
[LGTM Timeline notifier]Timeline:
|
| if err != nil { | ||
| return "", errors.Trace(err) | ||
| } | ||
| controllerID := response.Brokers[0].ID |
There was a problem hiding this comment.
Is it sure that the first broker is the controller ?
ti-chi-bot
bot
added
the
size/XXL
3AceShowHand
approved these changes
Jan 21, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/check-issue-triage-complete |
wk989898
added a commit
to wk989898/ticdc
that referenced
this pull request
Jan 24, 2025
…)" This reverts commit 492437c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #832
What is changed and how it works?
confluent-kafka-go is a lightweight wrapper around librdkafka, a finely tuned C client.
Notice
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note