Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Alert rules for PD do not respect leadership #982

Closed
aylei opened this issue Oct 8, 2019 · 3 comments · Fixed by #989
Closed

Alert rules for PD do not respect leadership #982

aylei opened this issue Oct 8, 2019 · 3 comments · Fixed by #989
Assignees
@aylei
Labels
bug

Comments

@aylei
Copy link
Contributor

aylei commented Oct 8, 2019

Some alert rules for PD do not respect leadership, for example, the rule sum ( pd_cluster_status{type="store_disconnected_count"} > 0 will sum up the disconnected store count from both leader and follower, which may cause fake alerts.
@aylei aylei added the bug label Oct 8, 2019
@aylei aylei self-assigned this Oct 8, 2019
@aylei aylei mentioned this issue Oct 11, 2019
Merged
@disksing
Copy link
Contributor

We have PR aims to fix it too tikv/pd#1790

@aylei
Copy link
Contributor Author

aylei commented Oct 11, 2019

@disksing Looks good, then do you think it is necessary to modify the alert rules for older versions of PD?

@disksing
Copy link
Contributor

Yes. Double-check is better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aylei aylei

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider PD leadership when calculating pd_cluster_status metric aylei/tidb-ansible
2 participants
@disksing @aylei