*: reset metrics after the leader steps down #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
==========================================
- Coverage 77.68% 77.63% -0.05%
==========================================
Files 166 166
Lines 16395 16431 +36
==========================================
+ Hits 12736 12756 +20
- Misses 2629 2636 +7
- Partials 1030 1039 +9
Continue to review full report at Codecov.
|
|
/run-unit-test |
shafreeck
suggested changes
Oct 10, 2019
nolouch
added
needs-cherry-pick-release-3.0
nolouch
reviewed
Oct 11, 2019
server/coordinator.go
Outdated
| storeID := s.GetID() | ||
| storeLabel := fmt.Sprintf("%d", storeID) | ||
| // Resets hot write metrics | ||
| hotSpotStatusGauge.WithLabelValues(storeAddress, storeLabel, "total_written_bytes_as_peer").Set(0) |
There was a problem hiding this comment.
Can we get all the label values? It's easy to ignore some clean up when we add new metrics. It seems the Desc() can get the LabelPair.
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
reset-metrics
branch
from
824ca0d to
80c2e7e
Compare
Signed-off-by: Ryan Leung <[email protected]>
|
PTAL @shafreeck @lhy1024 |
nolouch
approved these changes
Oct 12, 2019
|
PTAL @shafreeck |
nolouch
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-3.0 failed |
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Oct 17, 2019
Signed-off-by: Ryan Leung <[email protected]>
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Oct 17, 2019
Signed-off-by: Ryan Leung <[email protected]>
nolouch
pushed a commit
that referenced
this pull request
Oct 17, 2019
* *: reset metrics after the leader steps down (#1790) Signed-off-by: Ryan Leung <[email protected]> * *: improve label metrics (#1753) Signed-off-by: Ryan Leung <[email protected]>
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Ryan Leung <[email protected]>
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Ryan Leung <[email protected]>
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Ryan Leung <[email protected]>
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Mar 3, 2020
Signed-off-by: Ryan Leung <[email protected]>
disksing
pushed a commit
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #1415.
What is changed and how it works?
This PR resets the metrics when the leader steps down.
Check List
Tests