Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for DDL "set tiflash mode" #1172

Merged
merged 10 commits into from
Jul 8, 2022
Merged

Add test for DDL "set tiflash mode" #1172

merged 10 commits into from
Jul 8, 2022

Conversation

hongyunyan
Copy link
Contributor

@hongyunyan hongyunyan commented Jul 5, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #1175 pingcap/tidb#35850

What is changed and how it works?

This PR want to add an integration test to make sure "alter table xx set tiflash mode xx" works with the tools.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hongyunyan
Copy link
Contributor Author

/run-all-tests

@hongyunyan hongyunyan changed the title WIP:Add test for DDL "set tiflash mode" Add test for DDL "set tiflash mode" Jul 7, 2022
@hongyunyan
Copy link
Contributor Author

/run-all-tests

@hongyunyan
Copy link
Contributor Author

/run-unit-test

@hongyunyan
Copy link
Contributor Author

cc @breezewish @lichunzhu

lichunzhu
lichunzhu reviewed Jul 7, 2022
View reviewed changes
pkg/loader/load.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/S and removed size/M labels Jul 7, 2022
@hongyunyan
Copy link
Contributor Author

/run-all-tests

@hongyunyan
Copy link
Contributor Author

/run-unit-test

lichunzhu
lichunzhu approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongyunyan
Copy link
Contributor Author

/run-unit-test

breezewish
breezewish reviewed Jul 8, 2022
View reviewed changes
pkg/loader/load.go Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@breezewish: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Jul 8, 2022
@hongyunyan
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d2213c6

@ti-chi-bot ti-chi-bot merged commit fa2543d into pingcap:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees
No one assigned
Labels
first-time-contributor size/M status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hongyunyan @ti-chi-bot @lichunzhu @breezewish @Rustin170506