Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-started: add notice for test parallel with range #138

Merged
merged 8 commits into from
Sep 14, 2021

Conversation

feitian124
Copy link
Contributor

What issue does this PR solve?

What is changed:

get-started: add notice for test parallel with range

@feitian124
Copy link
Contributor Author

/cc @tisonkun

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @feitian124 ! This is definitely a common fault in Golang projects. I think you can also mention this pattern as a code style rule in contribute-to-tidb/code-style-and-quality-guide.md

@feitian124
Copy link
Contributor Author

feitian124 commented Sep 13, 2021

added section Some tips for range and goroutines in code-style-and-quality-guide.md, please review, thanks.
@tisonkun

@tisonkun tisonkun self-requested a review September 14, 2021 01:32
@tisonkun tisonkun merged commit 231f596 into pingcap:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants