Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add server_info ffi for TiFlash #22

Merged
merged 1 commit into from
Aug 19, 2021
Merged

add server_info ffi for TiFlash #22

merged 1 commit into from
Aug 19, 2021

Conversation

CalvinNeo
Copy link
Member

What problem does this PR solve?

Support fn_server_info to forward server info from proxy to TiFlash.

What is changed and how it works?

What's Changed:

add fn_server_info to RaftStoreProxyFFIHelper.
add ffi_server_info as implementation of fn_server_info.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note 

None

solotzg
solotzg reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to run cargo fmt before committing. Rest lgtm

components/server/src/server.rs Outdated Show resolved Hide resolved
components/server/src/server.rs Outdated Show resolved Hide resolved
raftstore-proxy/ffi/src/RaftStoreProxyFFI/@version Outdated Show resolved Hide resolved
@CalvinNeo CalvinNeo requested a review from solotzg August 18, 2021 06:18
solotzg
solotzg approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CalvinNeo CalvinNeo mentioned this pull request Aug 18, 2021
Merged
@solotzg solotzg merged commit fa27eb9 into pingcap:raftstore-proxy Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solotzg solotzg solotzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalvinNeo @solotzg