-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt(ticdc): support to overwrite the default cluster TLS cert secret name #5778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-pull-e2e-kind |
/run-pull-e2e-kind-across-kubernetes |
29e8f43
to
ebc894b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5778 +/- ##
===========================================
- Coverage 61.47% 46.98% -14.49%
===========================================
Files 235 219 -16
Lines 30653 30975 +322
===========================================
- Hits 18843 14553 -4290
- Misses 9920 14676 +4756
+ Partials 1890 1746 -144
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/cherry-pick release-1.6 |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
This PR introduces a new field
clusterTLSSecretName
intc.spec.ticdc
that support overwriting the default cluster TLS secret name. This is useful sharing the same mTLS cert secret for multiple ticdc clusters connecting to the same upstream tidb cluster.What is changed and how does it work?
Code changes
Tests
ticdc-tls
ticdc-tls
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.