feat(tidbgroup): refactor to use task v3 #6018
Conversation
liubog2008
commented
Dec 30, 2024
liubog2008
commented
- use task v3 for tidb group
- add more uts
- extract finalizer del task to common
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6018 +/- ##
==============================================
+ Coverage 42.47% 44.88% +2.40%
==============================================
Files 154 154
Lines 10130 10089 -41
==============================================
+ Hits 4303 4528 +225
+ Misses 5516 5256 -260
+ Partials 311 305 -6
|
pkg/controllers/tidbgroup/builder.go
Outdated
| // if it's paused just return | ||
| task.IfBreak(common.CondClusterIsPaused(state)), | ||
|
|
||
| // get all tikvs |
There was a problem hiding this comment.
| // get all tikvs | |
| // get all tidbs |
| selector := labels.SelectorFromSet(labels.Set{ | ||
| // TODO(liubo02): add label of managed by operator ? | ||
| v1alpha1.LabelKeyCluster: dbg.Spec.Cluster.Name, | ||
| v1alpha1.LabelKeyComponent: v1alpha1.LabelValComponentPD, | ||
| v1alpha1.LabelKeyGroup: dbg.Name, | ||
| }) | ||
|
|
||
| revisions, err := historyCli.ListControllerRevisions(dbg, selector) |
There was a problem hiding this comment.
only TiDB Operator will create revisions for dbg, right? I think it's better to add "managed by operator"
There was a problem hiding this comment.
lgtm. I'll add it in another PR
Signed-off-by: liubo02 <[email protected]>
Signed-off-by: liubo02 <[email protected]>
liubog2008
force-pushed
the
liubo02/refactor-tidb
branch
from
203e5be to
eb736f6
Compare
|
/run-pull-kind-e2e-v2 |
|
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
|
/run-pull-e2e-kind-v2 |
1 similar comment
|
/run-pull-e2e-kind-v2 |
Signed-off-by: liubo02 <[email protected]>
|
/run-pull-e2e-kind-v2 |
1 similar comment
|
/run-pull-e2e-kind-v2 |
|
/run-pull-e2e-kind-v2 |
|
@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
