Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync_diff: support json compare #674

Merged
merged 3 commits into from
Sep 21, 2022
Merged

sync_diff: support json compare #674

merged 3 commits into from
Sep 21, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Sep 12, 2022

What problem does this PR solve?

Issue Number: close #606

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lance6716
Copy link
Collaborator

/cc @Leavrth

@ti-chi-bot ti-chi-bot requested a review from Leavrth September 12, 2022 12:40
@Leavrth
Copy link
Contributor

Leavrth commented Sep 14, 2022

could you add some integration tests?

the script of generating table is here,
https://github.com/pingcap/tidb-tools/blob/master/tests/sync_diff_inspector/run.sh#L20

@Leavrth
Copy link
Contributor

Leavrth commented Sep 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28d99c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync_diff_inspector 的 json compare 不正确
5 participants