add more tests

Signed-off-by: xufei <[email protected]>
pingcap · Jun 20, 2024 · 29f60a5 · 29f60a5
1 parent c4db947
commit 29f60a5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/executor/join/hash_join_v2.go b/pkg/executor/join/hash_join_v2.go
@@ -46,8 +46,9 @@ var (
 
 // IsHashJoinV2Enabled return true if hash join v2 is enabled
 func IsHashJoinV2Enabled() bool {
-	// sizeOfUintptr should always equal to sizeOfUnsafePointer, add this check here in case in the future
-	// go runtime change this
+	// sizeOfUintptr should always equal to sizeOfUnsafePointer, because according to golang's doc,
+	// a Pointer can be converted to an uintptr. Add this check here in case in the future go runtime
+	// change this
 	return enableHashJoinV2.Load() && sizeOfUintptr >= sizeOfUnsafePointer
 }
 

diff --git a/pkg/executor/join/join_row_table_test.go b/pkg/executor/join/join_row_table_test.go
@@ -29,6 +29,10 @@ func TestFixedOffsetInRowLayout(t *testing.T) {
 	require.Equal(t, 8, sizeOfLengthField)
 }
 
+func TestUintptrCanHoldPointer(t *testing.T) {
+	require.Equal(t, true, sizeOfUintptr >= sizeOfUnsafePointer)
+}
+
 func TestJoinTableMetaKeyMode(t *testing.T) {
 	tinyTp := types.NewFieldType(mysql.TypeTiny)
 	intTp := types.NewFieldType(mysql.TypeLonglong)