address comments

pingcap · Nov 28, 2022 · 953273f · 953273f
1 parent e285406
commit 953273f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/planner/core/partition_pruner_test.go b/planner/core/partition_pruner_test.go
@@ -310,9 +310,6 @@ func TestListPartitionPruner(t *testing.T) {
 	partitionPrunerData.LoadTestCases(t, &input, &output)
 	valid := false
 	for i, tt := range input {
-		if tt == "select * from t1 where (id = 1 and a = 1) or a is null" {
-			fmt.Println("1")
-		}
 		testdata.OnRecord(func() {
 			output[i].SQL = tt
 			output[i].Result = testdata.ConvertRowsToStrings(tk.MustQuery(tt).Sort().Rows())

diff --git a/planner/core/task.go b/planner/core/task.go
@@ -1050,7 +1050,7 @@ func (p *PhysicalTopN) pushTopNDownToDynamicPartition(copTsk *copTask) (task, bo
 			return nil, false
 		}
 		finalTblScanPlan := copTsk.tablePlan
-		if len(finalTblScanPlan.Children()) > 0 {
+		for len(finalTblScanPlan.Children()) > 0 {
 			finalTblScanPlan = finalTblScanPlan.Children()[0]
 		}
 		tblScan = finalTblScanPlan.(*PhysicalTableScan)