Skip to content

Commit

Permalink
docs/design: address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
zimulala committed Apr 19, 2023
1 parent acb93d1 commit a7696c6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/design/2023-04-11-pause-user-ddl-when-upgrading.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Here are some roles for TiDB in the cluster (assuming upgrading from v7.1 to v7.
- Owner TiDB: The TiDB where the DDL owner in the cluster is located.

Specific upgrade process:
1. New TiDB: Check whether the old TiDB version is greater than or equal to v7.1, if not, then exit the whole process.
1. New TiDB: Check whether the old TiDB version is greater than or equal to v7.1, if not, then exit the whole process. That means the cluster upgrade process will follow legcy upgrade ways, that means User have to make sure there is no user issued DDL in running state.
2. Notify the cluster that all TiDB enters to pause executing user DDL operations. Notification method:
1. New TiDB: Set the PD path (for example: `/tidb/server/global_state` , use this path later) to the current TiDB version. In addition, in order to prevent multiple TiDB nodes from upgrading at the same time, it will check whether the value on the `/tidb/server/global_state` path is empty.
2. All TiDBs:
Expand Down Expand Up @@ -52,7 +52,7 @@ In the plan, we distinguish between DDL operation types. Among them, we distingu
- This feature is not supported when upgrading from v7.1 and previous versions.
- Other components
- During the upgrade process, the operation of some components is not supported, such as:
- BR, Lightning ( Physical Import Mode ) : The operation of this type of component cannot be processed during the upgrade process, because the DDL in the paused state may be copied to TiDB during these operations. However, the DDL in this state cannot be automatically resumed, which may lead to subsequent DDL block.
- Backup/Restore, Lightning ( Physical Import Mode ) : The operation of this type of component cannot be processed during the upgrade process, because the DDL in the paused state may be copied to TiDB during these operations. However, the DDL in this state cannot be automatically resumed, which may lead to subsequent DDL block.
- During the upgrade process, the operation of some components may be blocked, such as:
- DM, TiCDC and Lightning (Logical Import Mode) and other components. That is, during the upgrade process, import SQL to TiDB through such components, and there are DDL operations (if there is a system DDL operation that may have latent risk), then these DDL will be set to paused, causing this import operation to block.

Expand Down

0 comments on commit a7696c6

Please sign in to comment.