apply comments

pingcap · Oct 21, 2022 · a88390a · a88390a
1 parent 7f4dbdb
commit a88390a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/executor/infoschema_reader.go b/executor/infoschema_reader.go
@@ -1713,7 +1713,10 @@ func (e *memtableRetriever) setDataForTiKVRegionStatus(ctx sessionctx.Context) (
 			for _, tableID := range extractorTableIDs {
 				regionsInfo, err := e.getRegionsInfoForTable(tikvHelper, is, tableID)
 				if err != nil {
-					continue
+					if errors.ErrorEqual(err, infoschema.ErrTableExists) {
+						continue
+					}
+					return err
 				}
 				allRegionsInfo = allRegionsInfo.Merge(regionsInfo)
 			}
@@ -1736,11 +1739,8 @@ func (e *memtableRetriever) setDataForTiKVRegionStatus(ctx sessionctx.Context) (
 			if len(extractorTableIDs) == 0 {
 				e.setNewTiKVRegionStatusCol(&allRegionsInfo.Regions[i], &regionTableList[j])
 			}
-			for _, tableID := range extractorTableIDs {
-				if tableID == regionTableList[j].Table.ID {
-					e.setNewTiKVRegionStatusCol(&allRegionsInfo.Regions[i], &regionTableList[j])
-					break
-				}
+			if slices.Contains(extractorTableIDs, regionTableList[j].Table.ID) {
+				e.setNewTiKVRegionStatusCol(&allRegionsInfo.Regions[i], &regionTableList[j])
 			}
 		}
 	}