Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charset: full collations support for TiDB #14573

Closed
bb7133 opened this issue Jan 24, 2020 · 2 comments
Closed

charset: full collations support for TiDB #14573

bb7133 opened this issue Jan 24, 2020 · 2 comments
Labels
component/charset proposal type/enhancement The issue or PR belongs to an enhancement.
Milestone

Comments

@bb7133
Copy link
Member

bb7133 commented Jan 24, 2020

Feature Request

For now, TiDB supports binary collations only, we have several issues related to this limitation:

Now a proposal has been landed for all other collations from MySQL:

#14574

This issue is created for the discussions of rationales/options in this proposal, please feel free to express your opinions on the collations in TiDB, thank you!

@yayuntian
Copy link

I have high expectations for support utf8_general_ci

@SunRunAway SunRunAway modified the milestones: v4.0.0-beta.1, v4.0.1 May 28, 2020
@zz-jason zz-jason modified the milestones: v4.0.1, v4.0.2 Jun 5, 2020
@zz-jason zz-jason modified the milestones: v4.0.2, v4.0.3 Jun 19, 2020
@bb7133
Copy link
Member Author

bb7133 commented Jul 14, 2020

Close this issue since it has been done, please see https://github.com/pingcap/tidb/projects/33 for more details.

@bb7133 bb7133 closed this as completed Jul 14, 2020
SunRunAway added a commit to SunRunAway/community that referenced this issue Dec 3, 2020
Since @wjhuang2016 has contributed a lot to sig-exec, according to sig-exec [roles-and-organization-management.md#promotion](https://github.com/pingcap/community/blob/master/special-interest-groups/sig-exec/roles-and-organization-management.md#from-reviewer-to-committer), we would like to promote him to our new committer, and his detailed contribution is shown below:

contribute [30 PRs](https://github.com/pingcap/tidb/pulls?q=is%3Apr+author%3Awjhuang2016+label%3Asig%2Fexecution) to the executor,
support the [expression index](pingcap/tidb#18008) (a medium task)
support the [new collation](pingcap/tidb#14573) (a hard task)
help other contributors and review [150+](https://github.com/pingcap/tidb/pulls?q=is%3Apr+reviewed-by%3Awjhuang2016+-author%3Awjhuang2016+label%3Asig%2Fexecution) PRs.
Thanks for his contribution!!
ti-chi-bot pushed a commit to pingcap/community that referenced this issue Dec 3, 2020
Since @wjhuang2016 has contributed a lot to sig-exec, according to sig-exec [roles-and-organization-management.md#promotion](https://github.com/pingcap/community/blob/master/special-interest-groups/sig-exec/roles-and-organization-management.md#from-reviewer-to-committer), we would like to promote him to our new committer, and his detailed contribution is shown below:

contribute [30 PRs](https://github.com/pingcap/tidb/pulls?q=is%3Apr+author%3Awjhuang2016+label%3Asig%2Fexecution) to the executor,
support the [expression index](pingcap/tidb#18008) (a medium task)
support the [new collation](pingcap/tidb#14573) (a hard task)
help other contributors and review [150+](https://github.com/pingcap/tidb/pulls?q=is%3Apr+reviewed-by%3Awjhuang2016+-author%3Awjhuang2016+label%3Asig%2Fexecution) PRs.
Thanks for his contribution!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/charset proposal type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants