Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix the document, or evict the global variables cache immediately #22808

Closed
xhebox opened this issue Feb 19, 2021 · 3 comments
Closed
Assignees
Labels
severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@xhebox
Copy link
Contributor

xhebox commented Feb 19, 2021

Bug Report

refer to #14531 and #22806. While the behavior of this bug is expected, the documentation is problematic.

The description of this behavior is added by pingcap/docs-cn#2208 and pingcap/docs#1797, which describes that:

A single TiDB instance proactively gets the `GLOBAL` information and forms `gvc` (global variables cache) every 2 seconds.

But the document is modified to the misleading one in pingcap/docs-cn#4001 and pingcap/docs#3152.

Changes are also propagated to other TiDB servers every 2 seconds

All TiDB servers need to wait for changes to propagate, including the one you sent SET GLOBAL xxxx.

We either need to fix the document, or investigate if we can evict the GVC for the tidb-server you send SET GLOBAL xxxx immediately. I prefer the latter if it is possible to implement.

@xhebox xhebox added the type/bug The issue is confirmed as a bug. label Feb 19, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Feb 19, 2021

/label sig/infra

@morgo
Copy link
Contributor

morgo commented Jun 15, 2021

This has been updated in the docs.

@morgo morgo closed this as completed Jun 15, 2021
@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants