Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a better clarification on how sysvar changes "propagate" #5562

Merged
merged 2 commits into from
May 18, 2021
Merged

add a better clarification on how sysvar changes "propagate" #5562

merged 2 commits into from
May 18, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented May 5, 2021

What is changed, added or deleted? (Required)

The sysvar docs imply that the 2 second delay is propagation to other servers. This is not the case, there is no propagation at all, because the table is stored in TiKV. The delay is the global values cache, and thus it affects the issuing server as well.

This affects all versions, but master will hopefully have a fix soon so I'll create a separate PR to document the different semantics.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

For GA releases it is pingcap/tidb#22808

(I will leave the issue open until master is fixed)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 5, 2021 15:15
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2021
@morgo
Copy link
Contributor Author

morgo commented May 5, 2021

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox May 5, 2021 15:16
@morgo morgo mentioned this pull request May 5, 2021
Merged
11 tasks
@TomShawn
Copy link
Contributor

TomShawn commented May 6, 2021

/cc @zhangjinpeng1987
/hold
/assign
/label needs-cherry-pick-4.0
/translation doing

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-4.0 labels May 6, 2021
@ti-chi-bot ti-chi-bot requested a review from zhangjinpeng87 May 6, 2021 03:05
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 6, 2021
@xhebox
Copy link
Contributor

xhebox commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@xhebox: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed May 11, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 1 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2021
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@TomShawn
Copy link
Contributor

@morgo Can we merge this PR?

@morgo
Copy link
Contributor Author

morgo commented May 18, 2021

@morgo Can we merge this PR?

yes, it's ready to go.

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: afb446c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2021
@ti-chi-bot ti-chi-bot merged commit aaf35bb into pingcap:release-5.0 May 18, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5641.

ti-chi-bot added a commit that referenced this pull request May 18, 2021
@ti-chi-bot
add a better clarification on how sysvar changes "propagate" (#5562) (#…
74ed8b9 
…5641)
@TomShawn TomShawn added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Aug 5, 2021
@TomShawn TomShawn removed their assignment Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@xhebox xhebox Awaiting requested review from xhebox

@zhangjinpeng87 zhangjinpeng87 Awaiting requested review from zhangjinpeng87

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgo @TomShawn @xhebox @ti-chi-bot