Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context (context.Context) for planner preprocess #38359

Closed
Tracked by #38276
YangKeao opened this issue Oct 10, 2022 · 0 comments · Fixed by #38360
Closed
Tracked by #38276

Add context (context.Context) for planner preprocess #38359

YangKeao opened this issue Oct 10, 2022 · 0 comments · Fixed by #38360
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

YangKeao commented Oct 10, 2022

Enhancement

The planner preprocess procedure doesn't pass in the ctx context.Context. However, it's needed by #38274, as the stale-read preprocessor should send request to the pd with this ctx. The context is needed for killing the connection (and global deadline, tracing...).

It will bring a lot of changes to the related functions / tests. I don't know whether there are better ways to handle this.

@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Oct 10, 2022
ti-chi-bot pushed a commit that referenced this issue Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant