Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete useless delete useless SetTxnInfoSchema in TxnManager #44361

Closed
lcwangchao opened this issue Jun 2, 2023 · 0 comments · Fixed by #44362 or #45207
Closed

delete useless delete useless SetTxnInfoSchema in TxnManager #44361

lcwangchao opened this issue Jun 2, 2023 · 0 comments · Fixed by #44362 or #45207
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

Enhancement

TxnManager.SetTxnInfoSchema is useless and no one is using it. We should delete it.

BTW. It's better not to provide SetTxnInfoSchema because the infoschema should be determined by TxnManager it self
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Jun 2, 2023
@lcwangchao lcwangchao mentioned this issue Jun 2, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 2, 2023
@lcwangchao
txn: delete useless SetTxnInfoSchema in TxnManager (#44362)
9151f91 
close #44361
@lcwangchao lcwangchao mentioned this issue Jul 6, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 6, 2023
@lcwangchao
txn: remove TxnContextProvider.SetTxnInfoSchema (#45207)
63f6b48 
close #44361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@lcwangchao