Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable test TestRenameTableIntermediateState #44948

Closed
Tracked by #41316
hawkingrei opened this issue Jun 26, 2023 · 2 comments · Fixed by #50314
Closed
Tracked by #41316

unstable test TestRenameTableIntermediateState #44948

hawkingrei opened this issue Jun 26, 2023 · 2 comments · Fixed by #50314
Labels
component/test type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

     table_test.go:560: 
        	Error Trace:	ddl/table_test.go:560
        	            				ddl/util/callback/callback.go:124
        	            				ddl/job_table.go:449
        	            				util/wait_group_wrapper.go:154
        	            				src/runtime/asm_amd64.s:1598
        	Error:      	Expected value not to be nil.
        	Test:       	TestRenameTableIntermediateState
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x839a89f]
goroutine 573593 [running]:
github.com/pingcap/tidb/ddl_test.TestRenameTableIntermediateState.func1(0xc017fce840?)
	ddl/table_test.go:561 +0xff
github.com/pingcap/tidb/ddl/util/callback.(*TestDDLCallback).OnJobUpdated(0xc01e561b20, 0xc017fce840?)
	ddl/util/callback/callback.go:124 +0x1ea
github.com/pingcap/tidb/ddl.(*ddl).delivery2worker.func1()
	ddl/job_table.go:449 +0xdef
github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
	util/wait_group_wrapper.go:154 +0x6b
created by github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run
	util/wait_group_wrapper.go:152 +0x8d
-- 

https://tiprow.hawkingrei.com/view/gs/pingcapprow/pr-logs/pull/pingcap_tidb/44947/tiprow_fast_test/1673232837370712064

4. What is your TiDB version? (Required)

@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Jun 26, 2023
@hawkingrei
Copy link
Member Author

hawkingrei commented Jan 11, 2024

See it again

     result.go:49: 
        	Error Trace:	pkg/testkit/result.go:49
        	            				pkg/ddl/table_test.go:575
        	Error:      	Not equal: 
        	            	expected: "[1]\n"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1 @@
        	            	-[1]
        	            	 
        	Test:       	TestRenameTableIntermediateState 

https://tiprow.hawkingrei.com/view/gs/pingcapprow/pr-logs/pull/pingcap_tidb/50306/tiprow_fast_test/1745329975055093760#1:build-log.txt%3A7979

@tangenta tangenta added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants