Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary copy in the baseCollector #51246

Closed
hawkingrei opened this issue Feb 22, 2024 · 0 comments · Fixed by #51244
Closed

remove unnecessary copy in the baseCollector #51246

hawkingrei opened this issue Feb 22, 2024 · 0 comments · Fixed by #51244
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

Enhancement

baseCollector.FromProto will copy the bytes in the tipb.RowSampleCollector. it is unnecessary.
After FromProto, it will not be used again.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: remove unnecessary copy in the baseCollector hawkingrei/tidb
1 participant
@hawkingrei