statistics: remove unnecessary copy in the baseCollector

[hawkingrei]

What problem does this PR solve?

Issue Number: close #51246

Problem Summary:

What changed and how does it work?

baseCollector.FromProto will copy the bytes in the tipb.RowSampleCollector. it is unnecessary. After FromProto, it will not be used again.

BTW Someone said the protobuf have a problem to make statistics wrong if we remove this copy. so let us check it.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

Merging #51244 (fe383c4) into master (9ee46d4) will decrease coverage by 15.9002%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #51244         +/-   ##
=================================================
- Coverage   70.5917%   54.6915%   -15.9002%     
=================================================
  Files          1467       1577        +110     
  Lines        435011     602504     +167493     
=================================================
+ Hits         307082     329519      +22437     
- Misses       108658     250037     +141379     
- Partials      19271      22948       +3677     

Flag	Coverage Δ
integration	36.8034% <100.0000%> (?)
unit	70.3379% <100.0000%> (-0.0528%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.3670% <ø> (+5.4790%)	⬆️

[hawkingrei]

/retest

[winoros]

This copy is added since we met some strange problems when we introduced it.

Approve since we passed simple tests this time.

[Rustin170506]

Please fill in your PR description. This then becomes a really valuable resource for the future to understand why certain changes have been made.
Also, please mention the worry that we talked about on the lark.
Thanks!

/hold

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hi-rustin,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-22 10:09:43.413622365 +0000 UTC m=+524672.161245475: ☑️ agreed by winoros.
• 2024-02-22 10:16:24.457935439 +0000 UTC m=+525073.205558549: ☑️ agreed by hi-rustin.

[hawkingrei]

Please fill in your PR description. This then becomes a really valuable resource for the future to understand why certain changes have been made. Also, please mention the worry that we talked about on the lark. Thanks!

/hold

OK, I has updated all information.

[hawkingrei]

/unhold