Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning/OWNERS is not correctly updated when moving lightning directory out of br #52744

Closed
lyzx2001 opened this issue Apr 19, 2024 · 5 comments · Fixed by #52745
Closed

lightning/OWNERS is not correctly updated when moving lightning directory out of br #52744

lyzx2001 opened this issue Apr 19, 2024 · 5 comments · Fixed by #52745
Assignees
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@lyzx2001
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

tidb/br/OWNERS

Lines 4 to 10 in 69d7770

filters:
"(tidb-lightning\\.toml)$":
approvers:
- sig-critical-approvers-tidb-lightning
".*":
approvers:
- sig-approvers-br

2. What did you expect to see? (Required)

Moved to lightning/OWNERS.

3. What did you see instead (Required)

Did not move to lightning/OWNERS.

4. What is your TiDB version? (Required)

v8.1.0

@lyzx2001 lyzx2001 added the type/bug The issue is confirmed as a bug. label Apr 19, 2024
Copy link

ti-chi-bot bot commented Apr 19, 2024

@lyzx2001: The label(s) @affects-8.1 cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1.

In response to this:

/assign @lyzx2001
/label @affects-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
Copy link

ti-chi-bot bot commented Apr 19, 2024

@lyzx2001: The label(s) @affects-8.1 cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-ok-to-test, needs-more-info, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1.

In response to this:

/assign @lyzx2001
/label @affects-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lyzx2001
Copy link
Contributor Author

/assign @lyzx2001

@lyzx2001
Copy link
Contributor Author

/label affects-8.1

@ti-chi-bot ti-chi-bot bot added the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Apr 19, 2024
@lyzx2001
Copy link
Contributor Author

/severity moderate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants