Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve tidb_enable_historical_stats to avoid oom #53048

Closed
hawkingrei opened this issue May 7, 2024 · 0 comments · Fixed by #53046
Closed

improve tidb_enable_historical_stats to avoid oom #53048

hawkingrei opened this issue May 7, 2024 · 0 comments · Fixed by #53046
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

Enhancement

historical stats can facilitate the debugging of the issue. but it has some problems to lead the OOM. it must load all old stats, then write all stats into tikv. All stats in the memory will OOM.
we need to refactor all code of historical stats.
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label May 7, 2024
@hawkingrei hawkingrei mentioned this issue May 7, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 7, 2024
@hawkingrei
variable: disable tidb_enable_historical_stats by default (#53046)
81a7cf5 
close #53048
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 17, 2024
@hawkingrei @terry1purcell
variable: disable tidb_enable_historical_stats by default (pingcap#53046
e14ad95 
)

close pingcap#53048
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@hawkingrei @RidRisR
variable: disable tidb_enable_historical_stats by default (pingcap#53046
0adefd8 
)

close pingcap#53048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

variable: disable tidb_enable_historical_stats by default hawkingrei/tidb
1 participant
@hawkingrei