Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make restore tolerates "safe" changefeeds exist #53131

Closed
YuJuncen opened this issue May 9, 2024 · 0 comments · Fixed by #53121 or #53482
Closed

Make restore tolerates "safe" changefeeds exist #53131

YuJuncen opened this issue May 9, 2024 · 0 comments · Fixed by #53121 or #53482
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YuJuncen
Copy link
Contributor

YuJuncen commented May 9, 2024

Enhancement

In the current version, we will reject to restore once there is any changefeed.
This is too strict and not pretty friendly to the end user.

In fact, BR can safely import data if the changefeed has a checkpoint ts greater than the backup archive -- CDC won't try to emit data loaded by BR in any case.
@YuJuncen YuJuncen added the type/enhancement The issue or PR belongs to an enhancement. label May 9, 2024
@YuJuncen YuJuncen mentioned this issue May 9, 2024
Merged
5 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 15, 2024
@YuJuncen
br/restore: use a more relax check for changefeeds when restoring (#5…
b9b330a 
…3121)

close #53131
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 17, 2024
@YuJuncen @terry1purcell
br/restore: use a more relax check for changefeeds when restoring (pi…
a60de17 
…ngcap#53121)

close pingcap#53131
@YuJuncen YuJuncen mentioned this issue May 22, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 22, 2024
@YuJuncen
br/cdcutil: don't skip failed changefeeds (#53482)
595cc15 
close #53131
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@YuJuncen @RidRisR
br/restore: use a more relax check for changefeeds when restoring (pi…
3adf8e9 
…ngcap#53121)

close pingcap#53131
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@YuJuncen @RidRisR
br/cdcutil: don't skip failed changefeeds (pingcap#53482)
9702a4a 
close pingcap#53131
@fubinzh fubinzh mentioned this issue May 28, 2024
Open
@3pointer 3pointer mentioned this issue Jun 11, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@YuJuncen