Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine the buffer code in table package #54392

Closed
lcwangchao opened this issue Jul 2, 2024 · 0 comments · Fixed by #54539 or #54605
Closed

refine the buffer code in table package #54392

lcwangchao opened this issue Jul 2, 2024 · 0 comments · Fixed by #54539 or #54605
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

Enhancement

There are many buffers when AddRecord/UpdateRecord for table.Table. It's better to optimize those code to:

  • move the buffer management code to some objects to make it easier.
  • introduce a safer way to use these buffers.
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Jul 2, 2024
@lcwangchao lcwangchao mentioned this issue Jul 2, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 3, 2024
@lcwangchao
table: Use MutateBuffers to manage buffers (#54394)
db0f4c3 
ref #54392, ref #54397
@lcwangchao lcwangchao mentioned this issue Jul 4, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 10, 2024
@lcwangchao
table: provide some binlog related methods for binlog in `MutateConte…
f158c65 
…xt` (#54433)

ref #54392, ref #54397
@lcwangchao lcwangchao mentioned this issue Jul 10, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 4fe31ed Jul 12, 2024
@lcwangchao lcwangchao mentioned this issue Jul 15, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 17, 2024
@lcwangchao
table: CheckRowBuffer.GetRowToCheck returns chunk.Row to protect …
9794156 
…inner slices (#54605)

close #54392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@lcwangchao