Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace maps.Copy in exp used for clone with maps.Clone in std #55527

Closed
D3Hunter opened this issue Aug 20, 2024 · 0 comments · Fixed by #55530
Closed

replace maps.Copy in exp used for clone with maps.Clone in std #55527

D3Hunter opened this issue Aug 20, 2024 · 0 comments · Fixed by #55530
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Aug 20, 2024 •
edited
Loading

Enhancement

in https://go-review.googlesource.com/c/go/+/471400, maps.Clone is optimized to clone underlying buckets, not iterating each item as before.

for some test result see #54581
@D3Hunter D3Hunter added the type/enhancement The issue or PR belongs to an enhancement. label Aug 20, 2024
@D3Hunter D3Hunter mentioned this issue Aug 20, 2024
Merged
13 tasks
@D3Hunter D3Hunter changed the title replace maps.Copy in exp with maps.Clone in std replace maps.Copy in exp used for clone with maps.Clone in std Aug 20, 2024
@D3Hunter D3Hunter mentioned this issue Aug 20, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in adc7597 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: replace maps.Copy which is for map clone with std maps.Clone D3Hunter/tidb
1 participant
@D3Hunter