*: replace maps.Copy which is for map clone with std maps.Clone #55530
Conversation
ti-chi-bot
bot
added
release-note-none
| CurrentStmtPessimisticLockCache := make(map[string][]byte, len(tc.CurrentStmtPessimisticLockCache)) | ||
| maps.Copy(CurrentStmtPessimisticLockCache, tc.CurrentStmtPessimisticLockCache) |
There was a problem hiding this comment.
this is useless code, see #43530 (comment)
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55530 +/- ##
================================================
+ Coverage 72.8739% 75.4972% +2.6232%
================================================
Files 1576 1598 +22
Lines 440775 449369 +8594
================================================
+ Hits 321210 339261 +18051
+ Misses 99821 88846 -10975
- Partials 19744 21262 +1518
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, hawkingrei, lance6716, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…e-upstream * origin/master: parser: call `SetText` correctly for `CreateViewStmt` (#55520) lighting: expose limited fields for `kv.Session` (#55517) show: prefilter table name with like pattern and show full tables (#55396) Planner: Do not allow cardinality to go below 1 (#55242) *: replace maps.Copy which is for map clone with std maps.Clone (#55530) infoschema: add WithRefillOption for TableByName and TableByID (#55511) domain: change groupSize in splitForConcurrentFetch (#55518) ddl: fix resuming to wrong checkpoint when failed during adding index (#55506)
What problem does this PR solve?
Issue Number: close #55527
Problem Summary:
What changed and how does it work?
as title, some maps.Copy which are used to override old item are kept
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.