Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br debug decode is useless when the backupmeta file got split. #56296

Closed
kennytm opened this issue Sep 25, 2024 · 1 comment · Fixed by #56627
Closed

br debug decode is useless when the backupmeta file got split. #56296

kennytm opened this issue Sep 25, 2024 · 1 comment · Fixed by #56627
Assignees
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@kennytm
Copy link
Contributor

kennytm commented Sep 25, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. Generate a full backup locally br backup full -s '/tmp/testbr
  2. Decode the backupmeta file br debug decode -s '/tmp/testbr

2. What did you expect to see? (Required)

The entire content of the backupmeta can be readable in JSON

3. What did you see instead (Required)

We can only see the main backupmeta.json is referring to the split-off files:

{
  "ddls": [],
  "cluster_id": 7418281098110393269,
  "cluster_version": "8.1.0",
  "br_version": "«snip»",
  "version": 1,
  "file_index": {
    "meta_files": [
      {
        "name": "backupmeta.datafile.000000001",
        "sha256": "2XIqo5osORmCTs0fWf0T59xYI98i6nZ/5IdqYwNQmF0=",
        "size": 4623
      }
    ]
  },
  "end_version": 452789007127937031,
  "schema_index": {
    "meta_files": [
      {
        "name": "backupmeta.schema.000000002",
        "sha256": "p2CbZh4isJ7lRdFWDoa/rQEYsV+0jr/v2KzX0JT2GeE=",
        "size": 290142
      }
    ]
  },
  "new_collations_enabled": "True",
  "backup_size": 401424
}

and the split-off files are not decoded into JSON:

$ ls -aF1 /tmp/testbr
./
../
1/
backup.lock
backupmeta
backupmeta.datafile.000000001
backupmeta.json
backupmeta.schema.000000002
checkpoints/

4. What is your TiDB version? (Required)

checked on v8.1.0, master.

@kennytm kennytm added type/bug The issue is confirmed as a bug. component/br This issue is related to BR of TiDB. labels Sep 25, 2024
@kennytm kennytm added affects-8.1 This bug affects the 8.1.x(LTS) versions. and removed may-affects-8.1 labels Sep 27, 2024
@Leavrth Leavrth added affects-7.5 This bug affects the 7.5.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 labels Oct 11, 2024
@Leavrth Leavrth self-assigned this Oct 11, 2024
@BornChanger
Copy link
Contributor

i think this behavior change is a consequence of backup metadata v2 from 7.6 and above. cc @Leavrth

@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 6b72ec4 Nov 13, 2024
ti-chi-bot bot pushed a commit that referenced this issue Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants