-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a DDL subscriber to handle updates to the stats meta #57871
Labels
affects-8.5
This bug affects the 8.5.x(LTS) versions.
component/statistics
sig/planner
SIG: Planner
type/enhancement
The issue or PR belongs to an enhancement.
Comments
Rustin170506
added
component/statistics
sig/planner
SIG: Planner
type/enhancement
The issue or PR belongs to an enhancement.
labels
Dec 2, 2024
This was referenced Dec 2, 2024
13 tasks
13 tasks
13 tasks
13 tasks
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
close pingcap#57871 Signed-off-by: Rustin170506 <[email protected]>
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Dec 20, 2024
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-8.5
This bug affects the 8.5.x(LTS) versions.
component/statistics
sig/planner
SIG: Planner
type/enhancement
The issue or PR belongs to an enhancement.
Enhancement
We introduced a DDL notifier when developing the new priority queue to deliver DDL events in a highly durable manner.
However, the current stats meta handling still relies on an unreliable in-memory channel. Therefore, it would be better to use the DDL notifier to handle stats meta updates as well.
I tried this before, as seen in this PR. However, many of our test cases rely on the behavior where the unit tests do not handle DDL events by default, which caused a lot of test failures.
This time, I will keep the in-memory channel for testing purposes only. This will help reduce the effort required to fix all the broken tests.
The text was updated successfully, but these errors were encountered: