Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add a variable to control the back off time and disable txn auto retry by default #10266

Merged
merged 7 commits into from
May 8, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
Signed-off-by: Shuaipeng Yu <[email protected]>
jackysp committed May 5, 2019
commit f5255574d99fa3312b7a26e79465d65238bf8944
2 changes: 1 addition & 1 deletion kv/variables.go
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ type Variables struct {
// BackoffLockFast specifies the LockFast backoff base duration in milliseconds.
BackoffLockFast int

// BackOffWeight specifies the weight of the max back off time duration in milliseconds.
// BackOffWeight specifies the weight of the max back off time duration.
BackOffWeight int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backoff weight is a little confusion, how about directly set the max backoff time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many kinds of backoffs. Maybe set them separately in the future.


// Hook is used for test to verify the variable take effect.