executor: fix deadloop when exec replace with generated column #10357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TiDB will run into dead loop and exhausts large memory very soon if we execute
replace into values (...)
on a generated column. The bug can be reproduced as following:The root cause of this is we fetched key value from store for duplicated kv checks, but did not apply generated column rule.
What is changed and how it works?
Force remove duplicated key from
ReplaceExec.dupKVs
.This pr is not a totally solution to this problem, it solves the deadloop, but a
replace into
operation having duplicated unique key conflict on a generated column still fail now.I didn't find a suit method to calculate generated column value without building a logic planner, if anyone points out a workaround way, I will have a try to make this pr better.
Check List
Tests
Related changes