Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: make TestShowAnalyzeStatus more stable #11090

Merged
merged 3 commits into from
Jul 5, 2019
Merged

executor: make TestShowAnalyzeStatus more stable #11090

merged 3 commits into from
Jul 5, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve? 

----------------------------------------------------------------------
FAIL: show_stats_test.go:173: testSuite1.TestShowAnalyzeStatus

show_stats_test.go:183:
    c.Assert(len(result.Rows()), Equals, 2)
... obtained int = 4
... expected int = 2

What is changed and how it works?

If TestShowAnalyzeStatus run parallelly with others, the results would be affected.
use a new testShowStatsSuite for it.

Check List

Tests

  • No code

@tiancaiamao
executor: make TestShowAnalyzeStatus more stable
1cf5993 
If TestShowAnalyzeStatus run parallelly with others, the results would be affected.
use a new testShowStatsSuite for it.
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Jul 5, 2019 •
edited
Loading

Fix #10991 CI

@tiancaiamao
Copy link
Contributor Author

PTAL @eurekaka @lamxTyler

@tiancaiamao tiancaiamao changed the title executor: make TestShowAnalyzeStatus more stable executor: make TestShowAnalyzeStatus more stable Jul 5, 2019
eurekaka
eurekaka reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2019
alivxxx
alivxxx approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #11090 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #11090   +/-   ##
=========================================
  Coverage   81.012%   81.012%           
=========================================
  Files          419       419           
  Lines        89325     89325           
=========================================
  Hits         72364     72364           
  Misses       11724     11724           
  Partials      5237      5237

@tiancaiamao tiancaiamao merged commit 58f5632 into master Jul 5, 2019
@tiancaiamao tiancaiamao deleted the show-stats-test branch July 5, 2019 02:56
alivxxx pushed a commit to alivxxx/tidb that referenced this pull request Aug 8, 2019
@tiancaiamao @alivxxx
executor: make TestShowAnalyzeStatus more stable (pingcap#11090)
488ff35 
If TestShowAnalyzeStatus run parallelly with others, the results would be affected.
use a new testShowStatsSuite for it.
@alivxxx alivxxx mentioned this pull request Aug 8, 2019
Merged
sre-bot pushed a commit that referenced this pull request Aug 9, 2019
@alivxxx @sre-bot
executor: make TestShowAnalyzeStatus more stable (#11090) (#11684)
24380b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
component/test sig/execution SIG execution status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiancaiamao @eurekaka @alivxxx