-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add trace support for subquery #11182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11182 +/- ##
===========================================
Coverage 82.1068% 82.1068%
===========================================
Files 425 425
Lines 94360 94360
===========================================
Hits 77476 77476
Misses 11488 11488
Partials 5396 5396 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@tiancaiamao CI failed. |
8d40c5a
to
4cf49dc
Compare
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@tiancaiamao merge failed. |
/rebuild |
/run-all-tests |
success |
cherry pick to release-3.0 failed |
What problem does this PR solve?
Building a query plan may execute the subquery, but I've no idea what's happening.
For example, I don't why
executor.Compile
takes so long.In this commit, the trace support for subquery is added.
After this change, I know that
executor.Compile
is slow because it enters theEvalSubQuery
function from the following output:The result should display in a tree format view, I'll investigate the bug in the next PR.
What is changed and how it works?
Add
context.Context
to many functions parameter until adding this code is possible inplannercore.EvalSubquery
:Check List
Tests
Code changes
Related changes