DDL: fix a bug in column charset and collate when create table and modify column (#11300) #11424
Conversation
AilinKid
changed the title
AilinKid
changed the title
bb7133
added
status/LGT2
bb7133
changed the title
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-all-tests |
| } | ||
| if len(tp.Charset) == 0 { | ||
| tp.Charset = derivedCollation.CharsetName | ||
| } else if tp.Charset != derivedCollation.CharsetName { |
There was a problem hiding this comment.
Is it dead code in this else if clause? The condition len(tp.Charset) in line 319 is always to be true, because line 301 checks the same thing.
There was a problem hiding this comment.
Is it dead code in this
else ifclause? The conditionlen(tp.Charset)in line 319 is always to be true, because line 301 checks the same thing.
The condition len(tp.Charset) in line 319 not always to be true. For the first time, it is. After we assigned charset to it, it should be judged in following loop.
| op := def.Options[i] | ||
| if op.Tp == ast.ColumnOptionCollate { | ||
| specifiedCollates = append(specifiedCollates, op.StrValue) | ||
| def.Options = append(def.Options[:i], def.Options[i+1:]...) |
There was a problem hiding this comment.
What will happen if we don't delete the ColumnOptionCollate option in ColumnDef?
There was a problem hiding this comment.
What will happen if we don't delete the
ColumnOptionCollateoption in ColumnDef?
Here if we don't remove it in Option, it is ok for the subsequent logic, not a big deal.
But for ast.Restore func, it will cause duplicate collate in restored SQL string.
AilinKid
force-pushed
the
fix_collate_3.0
branch
from
03a88a3 to
8373888
Compare
|
/run-all-tests |
|
/run-all-tests |
|
/rebuild |
What problem does this PR solve?
cherry-pick to release 3.0 #11300
Check List
Tests