expression: improve the compatibility with mysql when datatime is invalid. #11445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-yoko
force-pushed
the
fix_issue_11304
branch
from
8d37348 to
918932f
Compare
|
|
ono-yoko
force-pushed
the
fix_issue_11304
branch
from
6863053 to
e727691
Compare
ono-yoko
force-pushed
the
fix_issue_11304
branch
from
e727691 to
220e8a5
Compare
|
@XuHuaiyu @SunRunAway PTAL Thanks in advance. I do not have any right to run test or adding label. ;) |
SunRunAway
added
component/expression
contribution
ono-yoko
force-pushed
the
fix_issue_11304
branch
from
6592eed to
48f8890
Compare
SunRunAway
previously requested changes
Jul 25, 2019
|
@ono-yoko Please take a look at the CI problem. |
|
@SunRunAway Done. It seems I forgot to check err in test. |
|
/run-all-tests |
|
/run-auto-merge |
SunRunAway
added
status/can-merge
|
@SunRunAway I just checked ci failure. I do not think it has something to do with my change. |
Codecov Report
@@ Coverage Diff @@
## master #11445 +/- ##
================================================
- Coverage 81.5026% 81.3641% -0.1386%
================================================
Files 424 424
Lines 92197 90814 -1383
================================================
- Hits 75143 73890 -1253
+ Misses 11735 11610 -125
+ Partials 5319 5314 -5 |
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11447 |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
It is rather easy fix, just preparing a correct string and pass it into ErrorDataTimeFormat error.
In this way, the wanting message looks correct.
This PR closes #11304
Check List
Tests
Code changes
Side effects
No side effects
Related changes