Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: move failpoint test case to seq test suite #11525

Merged
merged 5 commits into from
Jul 30, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jul 30, 2019

Signed-off-by: Shuaipeng Yu [email protected]

What problem does this PR solve?

The ut test in #11522 failed, it returned an unexpected retryable error, which could be a mocked error.

What is changed and how it works?

Move the mocked failpoint case to seq cases.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2019
@coocood
Copy link
Member

coocood commented Jul 30, 2019

LGTM

coocood
coocood previously approved these changes Jul 30, 2019
@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Jul 30, 2019

/run-all-tests

@lonng
Copy link
Contributor

lonng commented Jul 30, 2019

LGTM

@jackysp jackysp merged commit 8bc6397 into pingcap:master Jul 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2019

cherry pick to release-3.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants