*: disable batch DMLs by default #13081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <[email protected]>
Signed-off-by: Shuaipeng Yu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #13081 +/- ##
===========================================
Coverage 80.2724% 80.2724%
===========================================
Files 469 469
Lines 112153 112153
===========================================
Hits 90028 90028
Misses 15197 15197
Partials 6928 6928 |
alivxxx
reviewed
Nov 4, 2019
statistics/handle/update.go
Outdated
| h.mu.Unlock() | ||
| }() | ||
| for { | ||
| sql := fmt.Sprintf("delete from mysql.stats_feedback where table_id = %d and hist_id = %d and is_index = %d", tableID, histID, isIndex) |
There was a problem hiding this comment.
Why not directly add limit here? The error handling would be simpler.
And maybe 100000 is too large, what about 10000?
Signed-off-by: Shuaipeng Yu <[email protected]>
|
LGTM |
tiancaiamao
reviewed
Nov 6, 2019
statistics/handle/update.go
Outdated
| h.mu.ctx.GetSessionVars().BatchDelete = false | ||
| h.mu.Unlock() | ||
| return errors.Trace(err) | ||
| defer func() { |
Signed-off-by: Shuaipeng Yu <[email protected]>
|
LGTM |
tiancaiamao
approved these changes
Nov 7, 2019
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
@jackysp merge failed. |
|
/run-unit-test |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Batching commit a DML statement is useless when TiDB supports larger transaction.
What is changed and how it works?
Disable it by default.
Check List
Tests
Code changes
Side effects
Related changes