Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make TestSplitRegionTimeout stable #13152

Merged
merged 4 commits into from
Nov 6, 2019

Conversation

SunRunAway
Copy link
Contributor

What problem does this PR solve?

Fix #13147

What is changed and how it works?

Do not sleep in test. use channel.

Check List

Tests

  • Unit test

@SunRunAway SunRunAway added sig/execution SIG execution component/test type/bugfix This PR fixes a bug. labels Nov 5, 2019
@SunRunAway SunRunAway requested a review from bb7133 November 5, 2019 08:51
@bb7133
Copy link
Member

bb7133 commented Nov 5, 2019

PTAL @zimulala

zimulala
zimulala previously approved these changes Nov 5, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala dismissed their stale review November 5, 2019 11:29

less One LGTM

@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. and removed type/bugfix This PR fixes a bug. labels Nov 5, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

/run-all-tests

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #13152 into master will increase coverage by 0.0574%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #13152        +/-   ##
================================================
+ Coverage   80.1934%   80.2509%   +0.0574%     
================================================
  Files           469        468         -1     
  Lines        111640     111499       -141     
================================================
- Hits          89528      89479        -49     
+ Misses        15231      15163        -68     
+ Partials       6881       6857        -24

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

@SunRunAway merge failed.

@SunRunAway
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit aaaf254 into pingcap:master Nov 6, 2019
@SunRunAway SunRunAway deleted the TestSplitRegionTimeout branch November 6, 2019 03:27
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit test in TestSplitRegionTimeout fails randomly
5 participants