*: lock unchanged rows for pessimistic transaction #14045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
added
type/bugfix
coocood
requested review from
cfzjywxk,
youjiali1995,
sticnarf and
tiancaiamao
Codecov Report
@@ Coverage Diff @@
## master #14045 +/- ##
===============================================
- Coverage 80.4293% 80.1644% -0.265%
===============================================
Files 482 482
Lines 122367 120904 -1463
===============================================
- Hits 98419 96922 -1497
- Misses 16219 16246 +27
- Partials 7729 7736 +7 |
tiancaiamao
reviewed
Dec 13, 2019
| tk.MustExec("update unchanged set c = 1 where id < 2") | ||
|
|
||
| tk2.MustExec("begin pessimistic") | ||
| err := tk2.ExecToErr("select * from unchanged where id = 1 for update nowait") |
There was a problem hiding this comment.
How long does the lock time out, would it block the CI ?
There was a problem hiding this comment.
No, it returns an error instantly.
|
Mostly LGTM |
|
LGTM |
|
@jackysp PTAL |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #14049 |
coocood
added a commit
to coocood/tidb
that referenced
this pull request
Dec 13, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 16, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The pessimistic lock is not acquired if a row is unchanged.
What is changed and how it works?
Add the unchanged row key to TxnCtx, later collect them before calling LockKeys.
Check List
Tests
Related changes
Release note