Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix data races detected by go test -race #1407

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Conversation

coocood
Copy link
Member

@coocood coocood commented Jul 7, 2016

No description provided.

@@ -68,7 +68,11 @@ type Server struct {

// ConnectionCount gets current connection count.
func (s *Server) ConnectionCount() int {
return len(s.clients)
var l int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/l/cnt/

@shenli
Copy link
Member

shenli commented Jul 7, 2016

@disksing PTAL

@disksing
Copy link
Contributor

disksing commented Jul 7, 2016

LGTM

@shenli
Copy link
Member

shenli commented Jul 7, 2016

LGTM

@coocood coocood merged commit 4eca9cc into master Jul 7, 2016
@coocood coocood deleted the coocood/fix-data-races branch July 7, 2016 07:35
3pointer added a commit to 3pointer/tidb that referenced this pull request Aug 6, 2021
3b1308e89 lightning: evaluate all generated columns even if they are virtual (pingcap#1407)
1b0e54c2f lightning: check and restore pd scheduler even if our task failed (pingcap#1336)
073d3596c lightning: fix the bug that calculate unfinished ranges may miss some range (pingcap#1413)
82ff927df backup: refine backup log for tracing backup tasks (pingcap#1335)
e907562e8 lightning: make create table ddl compatible with clustered index (pingcap#1364)
b6cab4b27 lightning: auto configure for parallel import (pingcap#1387)

git-subtree-dir: br
git-subtree-split: 3b1308e89de39325c3f0aa8931aebdf56db663f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants