Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demonstration of inline projection for sort #14353

Closed
wants to merge 3 commits into from

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Jan 6, 2020

What problem does this PR solve?

demonstration of inline projection for sort

  1. Planner: prune output columns in LogicalSort
  2. Executor: do not copy columns that output doesn't need in SortExec

What is changed and how it works?

name                                                   old time/op    new time/op    delta
SortExec/(rows:3000000,_orderBy:[0],_output:[1_2])-12     4.27s ± 3%     4.04s ± 3%   -5.48%  (p=0.016 n=5+5)
SortExec/(rows:3000000,_orderBy:[0],_output:[1])-12       4.26s ± 2%     3.83s ± 3%  -10.02%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
SortExec/(rows:3000000,_orderBy:[0],_output:[1_2])-12    27.9MB ± 0%    27.9MB ± 0%   -0.13%  (p=0.008 n=5+5)
SortExec/(rows:3000000,_orderBy:[0],_output:[1])-12      27.9MB ± 0%    27.8MB ± 0%   -0.26%  (p=0.008 n=5+5)

name                                                   old allocs/op  new allocs/op  delta
SortExec/(rows:3000000,_orderBy:[0],_output:[1_2])-12     41.1k ± 0%     41.1k ± 0%   -0.03%  (p=0.029 n=4+4)
SortExec/(rows:3000000,_orderBy:[0],_output:[1])-12       41.1k ± 0%     41.1k ± 0%   -0.07%  (p=0.029 n=4+4)

@SunRunAway SunRunAway requested a review from a team as a code owner January 6, 2020 06:27
@ghost ghost requested review from eurekaka and winoros and removed request for a team January 6, 2020 06:27
@SunRunAway SunRunAway changed the title implement inline projection for sort [WIP]implement inline projection for sort Jan 6, 2020
@SunRunAway
Copy link
Contributor Author

SunRunAway commented Jan 8, 2020

It's just for demonstration. Will create a proposal.

@SunRunAway SunRunAway closed this Jan 8, 2020
@SunRunAway SunRunAway deleted the inlineprojection-2 branch January 8, 2020 10:01
@SunRunAway SunRunAway changed the title [WIP]implement inline projection for sort demonstration of inline projection for sort Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant