*: support partition table in tiflash #14735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs <[email protected]>
crazycs520
added
type/enhancement
|
/rebuild |
|
/run-build-image |
Deardrops
reviewed
Feb 12, 2020
Signed-off-by: crazycs <[email protected]>
…into tiflash-partition
Signed-off-by: crazycs <[email protected]>
djshow832
reviewed
Feb 12, 2020
|
LGTM |
tangenta
reviewed
Feb 12, 2020
Co-Authored-By: tangenta <[email protected]>
Signed-off-by: crazycs <[email protected]>
tangenta
added
status/LGT2
zimulala
reviewed
Feb 12, 2020
ddl/table.go
Outdated
| break | ||
| } | ||
| } | ||
| tblInfo.TiFlashReplica.Available = false |
There was a problem hiding this comment.
How do we deal with it when the physical ID is not found in tblInfo.TiFlashReplica.AvailablePartitionIDs?
There was a problem hiding this comment.
Good catch, this line should put in line #765;
If physical ID is not found, do nothing, just ignore it will be ok.
Signed-off-by: crazycs <[email protected]>
zimulala
added
status/LGT3
|
/run-all-tests |
crazycs520
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Feb 13, 2020
Signed-off-by: crazycs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs [email protected]
What problem does this PR solve?
Support set tiflash replica for partition table.
For the partition table, need a separate variable for separate partition to indicate the partition tiflash replica was available. Only when the all partition table replica was available, then the table tiflash replica was available.
Related Parser PR: pingcap/parser#742
What is changed and how it works?
For partition table tiflash replica.
/tiflash/replicashould return partition ID, not table ID./tiflash/replica, it should treat the id as partition ID.Check List
Tests
Code changes
Side effects
Related changes
Release note