expression: return binary charset and collation if there is no string-type argument in DeriveCollationFromExprs
#15250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
wshwsh12 and
XuHuaiyu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15250 +/- ##
===========================================
Coverage 80.5354% 80.5354%
===========================================
Files 503 503
Lines 134398 134398
===========================================
Hits 108238 108238
Misses 17685 17685
Partials 8475 8475 |
|
Fixed, PTAL @bb7133 @wjhuang2016 |
|
/run-unit-test |
winoros
approved these changes
Mar 10, 2020
wjhuang2016
added
status/LGT2
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/run-unit-test |
This was referenced Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Update the function
DeriveCollationFromExprsto let it returnbinarycharset and collation if there is no string-type argument.Check List
Tests