server: fix SIGSEGV caused by port probing with audit plugin #16038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
added
component/plugin
component/server
needs-cherry-pick-3.0
type/bugfix
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #16038 +/- ##
================================================
- Coverage 80.5421% 80.4725% -0.0696%
================================================
Files 507 506 -1
Lines 136613 135343 -1270
================================================
- Hits 110031 108914 -1117
+ Misses 18062 17918 -144
+ Partials 8520 8511 -9 |
|
/merge |
1 similar comment
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #16064 |
|
cherry pick to release-3.1 in PR #16065 |
sre-bot
added a commit
that referenced
this pull request
Apr 7, 2020
lysu
added a commit
to sre-bot/tidb
that referenced
this pull request
Apr 7, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 7, 2020
jackysp
pushed a commit
to jackysp/tidb
that referenced
this pull request
May 19, 2020
shuke987
pushed a commit
that referenced
this pull request
May 19, 2020
…#17291) Co-authored-by: lysu <[email protected]>
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
May 19, 2020
…#16038) (pingcap#17291) Co-authored-by: lysu <[email protected]>
jackysp
added a commit
to bb7133/tidb
that referenced
this pull request
May 19, 2020
server: fix SIGSEGV caused by port probing with audit plugin (pingcap#16038)…(pingcap#17291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #16037
Problem Summary:
port probing will establish tcp connection, then exit without send any auth packet, so conn's session ctx should be nil and this cause crash in audit plugin code path.
What is changed and how it works?
What's Changed:
ensure session ctx is not nil before do reject audit.
How it Works:
check nil
Related changes
Check List
Tests
Side effects
Release note
This change is