-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: add max_allowed_packet check in concat/concat_ws (#11137) #16175
Merged
sre-bot
merged 3 commits into
pingcap:release-2.1
from
sre-bot:release-2.1-593fb7def59c
Apr 14, 2020
Merged
expression: add max_allowed_packet check in concat/concat_ws (#11137) #16175
sre-bot
merged 3 commits into
pingcap:release-2.1
from
sre-bot:release-2.1-593fb7def59c
Apr 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
zz-jason
reviewed
Apr 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wjhuang2016
reviewed
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for 16326, 16310, 16008, 16009 |
/run-all-tests |
zz-jason
approved these changes
Apr 14, 2020
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/2.1-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #11137 to release-2.1
What problem does this PR solve?
Return
NULL
and a warning when the result of functionconcat
orconcat_ws
exceedsmax_allowed_packet
. ref: #7153After this PR,
What is changed and how it works?
add max_allowed_packet check during
evalString
inbuiltinConcatWSSig
andbuiltinConcatSig
Check List
Tests
Related changes