expression: fix a bug that the coercibility of user variable is wrong #17676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wjhuang2016 <[email protected]>
bb7133
added
status/LGT2
|
Sorry @bb7133, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part |
|
/merge |
|
Sorry @wjhuang2016, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part |
|
/merge |
|
Sorry @wjhuang2016, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part |
Codecov Report
@@ Coverage Diff @@
## master #17676 +/- ##
===========================================
Coverage 79.4949% 79.4949%
===========================================
Files 524 524
Lines 141887 141887
===========================================
Hits 112793 112793
Misses 19994 19994
Partials 9100 9100 |
|
/merge |
|
Sorry @wjhuang2016, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part |
|
/merge |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 10, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-4.0 in PR #17890 |
bb7133
pushed a commit
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 [email protected]
What problem does this PR solve?
Issue Number: close #17675
Problem Summary:
We didn't handle the coercibility for user variables.
What is changed and how it works?
Set the coercibility of user variables to CoercibilityImplicit.
Related changes
Check List
Tests
Side effects
Release note