-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: remove sensitive information in slow-log and statement (#18107) #18129
executor: remove sensitive information in slow-log and statement (#18107) #18129
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflict @crazycs520
executor/adapter.go
Outdated
if costTime < threshold && level > zapcore.DebugLevel { | ||
return | ||
} | ||
sql := FormatSQL(a.Text, sessVars.PreparedParams) | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflict @crazycs520
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zimulala,Thanks for you review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AilinKid,Thanks for your review. |
/run-all-tests |
/rebuild |
/merge |
/run-all-tests |
cherry-pick #18107 to release-3.1
Signed-off-by: crazycs520 [email protected]
What problem does this PR solve?
Before this PR, TiDB slow log will record sensitive information such as passwords in slow-log query.
This PR remove sensitive information in slow-log. Such as below:
execute below sql:
The related slow-log will be:
the related statement will be:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
Release note