-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search logs: update sysutil to support search logs include invalid lines #18579
search logs: update sysutil to support search logs include invalid lines #18579
Conversation
Signed-off-by: baurine <[email protected]>
@breeswish @crazycs520 PTAL, thanks! |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you need to run go mod tidy
. The rest LGTM, thanks!
Codecov Report
@@ Coverage Diff @@
## master #18579 +/- ##
================================================
- Coverage 79.4761% 79.4727% -0.0035%
================================================
Files 540 540
Lines 145655 145572 -83
================================================
- Hits 115761 115690 -71
+ Misses 20561 20558 -3
+ Partials 9333 9324 -9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@baurine merge failed. |
/run-check_dev_2 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #18610 |
…nes (#18579) (#18610) * cherry pick #18579 to release-4.0 Signed-off-by: ti-srebot <[email protected]> * resolve conflicts Signed-off-by: baurine <[email protected]> Co-authored-by: Sparkle <[email protected]> Co-authored-by: baurine <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: jebter <[email protected]>
Signed-off-by: baurine [email protected]
What problem does this PR solve?
Related issues and PRs:
Problem Summary:
What is changed and how it works?
What's Changed:
Related changes
Check List
Tests
Release note