expression: check ErrTruncate/Overflow for CastRealAsDecimalSig (#18961) #18967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
component/expression
type/4.0-cherry-pick
type/bugfix
|
lgtm |
ti-srebot
added
status/LGT2
wshwsh12
approved these changes
Aug 4, 2020
|
/merge |
|
Sorry @SunRunAway, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-integration-copr-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18961 to release-4.0
What problem does this PR solve?
Issue Number: close #16147
Problem Summary:
Before this commit, the truncate/overflow error of children of
builtinArithmeticIntDivideDecimalSigis checked inbuiltinArithmeticIntDivideDecimalSig.vecEvalInt. But when the error happens, thebuf[0]orbuf[1]maybe not initialized, and thus cause theshould ensure all columns have the same lengthpanic inMergeNulls.What is changed and how it works?
Proposal: xxx
What's Changed:
Remove the check for children's truncate/overflow error in
builtinArithmeticIntDivideDecimalSigHow it Works:
Related changes
Check List
Tests
exists test
Side effects
N/A
Release note